-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rename either the "Image" type or its "image" spec property #40
Comments
I'd suggest renaming the CRD to |
I like that suggestion, especially as it's not a compound word. |
#63 renames image to tag. This mirrors the terminology that uses tag to reference a fully qualified tag. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
https://github.com/pivotal/build-service-system/blob/7ce7c912f99f160c548e86c25ea89892e27ab0e2/pkg/apis/build/v1alpha1/image_types.go#L39
If "image" is only one part of the type (e.g. "source" and "builder" being others), then it seems like the type should have a name that captures its breadth. Most users will probably consider "image" to be an atomic, immutable thing that sits in a registry as opposed to the name of the configuration for building multiple revisions of actual images. I don't have any particular suggestion for the latter, but the fact that the generated "Build" instances would be stamped out from this does imply that it could have "Build" in its name. Alternatively, the current Build type could be renamed to reflect it being a single execution/instance allowing this to be called "Build" instead. If I understand correctly, it would after all be the primary top-level type with which users of the "Build Service" interact.
The text was updated successfully, but these errors were encountered: