Handle ESC \ string terminators in OSC and APC #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This includes a small tidyup of the parser modes enum
pda
approved these changes
Jul 2, 2024
DrJosh9000
force-pushed
the
handle-escape-backslash-string-terminators
branch
from
46025ee to
79d8492
Compare
|
I was shown some input (from a customer) that rendered strangely, which led me down the path of this fix, and I've tested it on that input. |
This was referenced Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #101 - note the description of #101 is a bit off.
0x9Cis historical as a string terminator (ST), but a common ST in use today (e.g. for hyperlinks with the extensionESC ]8;;link ST) is actually the two byte sequenceESC \.This is relevant to #58 as this is a step towards accepting at least one hyperlink extension known to iTerm (and others) in its possible forms. However this PR will break this amazing hack...
This PR includes a small tidyup of the parser modes enum. We don't use shouty-case constants in Go.