Cache responses in Cloudfront #2077
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Our CSP is currently in reporting mode so not blocking anything at the moment meaning this won't change the current behaviour. By removing our nonce hash we can effectively start caching pages that use inline scripts since the content won't change between requests.
Signup / Login both redirect to the Dashboard
|
Your Render PR Server URL is https://bk-docs-pr-2077.onrender.com. Follow its progress at https://dashboard.render.com/web/srv-ch31cnpmbg57g9rkt97g. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cloudfront CDN now sits between the client and our application which means we can start thinking about caching HTTP responses for a snappier user experience.
This PR does a few things to enable HTTP caching.
probably_authenticatedcheck we can serve up the same cached response for all HTTP requests. A user can still access their dashboard by clicking either of those links once they're logged in.Cache-Controlheaders:public– this one lets Cloudfront know it's allowed to cache itmax-age- controls how long to cache content. I've set this to 5 minutes whilst testing.must-revalidated- check origin server (our app) to see if content is still fresh using etagnoncegeneration 😬inline-eval(see backport algolia search support from buildkite.com #681) .