Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Roko v1.3.1 #3157

Merged
merged 2 commits into from
Jan 14, 2025
Merged

Roko v1.3.1 #3157

merged 2 commits into from
Jan 14, 2025

Conversation

moskyb
Copy link
Contributor

@moskyb moskyb commented Jan 14, 2025

Description

This PR fixes two issues introduced in #3153:

  • The roko retrier would lie about the time it was going to retry in when jitter was enabled - see Don't lie about retrying in when jitter is enabled roko#18. This problem is solved by updating to roko v1.3.1, which includes the PR linked.
  • In the acquire-job retry loop, in some cases, the server can set the amount of time that the retrier can retry in. However, because the Retrying in... message was logged prior to setting the next interval, the retrier would log the interval it calculated instead of the interval that the backend told it to use. This issue is resolved by simply logging after we set the next retry interval.

Testing

  • Tests have run locally (with go test ./...). Buildkite employees may check this if the pipeline has run automatically.
  • Code is formatted (with go fmt ./...)

This should make the logs lie less about when retries are going to happen
@moskyb moskyb requested a review from a team January 14, 2025 04:45
Copy link
Contributor

@CerealBoy CerealBoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@moskyb moskyb enabled auto-merge January 14, 2025 04:56
@moskyb moskyb merged commit 0ddf5f9 into main Jan 14, 2025
1 check passed
@moskyb moskyb deleted the roko-1.3.1 branch January 14, 2025 05:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants