Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unusable image pull policy options #508

Conversation

DrJosh9000
Copy link
Contributor

@DrJosh9000 DrJosh9000 commented Feb 13, 2025

Fixes #486

@DrJosh9000 DrJosh9000 force-pushed the sup-3255-imagecheckpullpolicy-gets-overriden-by-imagepullpolicy-issue branch 4 times, most recently from 637df90 to d6825cc Compare February 13, 2025 06:57
@DrJosh9000 DrJosh9000 marked this pull request as ready for review February 13, 2025 06:57
@DrJosh9000 DrJosh9000 requested a review from a team as a code owner February 13, 2025 06:57
@DrJosh9000 DrJosh9000 force-pushed the sup-3255-imagecheckpullpolicy-gets-overriden-by-imagepullpolicy-issue branch from d6825cc to b529bab Compare February 13, 2025 07:57
Copy link
Contributor

@petetomasik petetomasik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DrJosh9000 DrJosh9000 merged commit da7fae6 into main Feb 13, 2025
1 check passed
@DrJosh9000 DrJosh9000 deleted the sup-3255-imagecheckpullpolicy-gets-overriden-by-imagepullpolicy-issue branch February 13, 2025 20:06
tomowatt added a commit that referenced this pull request Feb 22, 2025
commit 6f64ff9
Merge: 13590af b61ec79
Author: Pete Tomasik <[email protected]>
Date:   Thu Feb 20 16:46:52 2025 -0500

    Merge pull request #521 from buildkite/update-readme

    [SUP-3361] Update readme with information about queue pause config

commit 13590af
Merge: bec04fe 1837b16
Author: Pete Tomasik <[email protected]>
Date:   Thu Feb 20 16:45:17 2025 -0500

    Merge pull request #513 from buildkite/dependabot/go_modules/github.com/spf13/cobra-1.9.1

    Bump github.com/spf13/cobra from 1.8.1 to 1.9.1

commit 1837b16
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Thu Feb 20 18:09:08 2025 +0000

    Bump github.com/spf13/cobra from 1.8.1 to 1.9.1

    Bumps [github.com/spf13/cobra](https://github.com/spf13/cobra) from 1.8.1 to 1.9.1.
    - [Release notes](https://github.com/spf13/cobra/releases)
    - [Commits](spf13/cobra@v1.8.1...v1.9.1)

    ---
    updated-dependencies:
    - dependency-name: github.com/spf13/cobra
      dependency-type: direct:production
      update-type: version-update:semver-minor
    ...

    Signed-off-by: dependabot[bot] <[email protected]>

commit bec04fe
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Thu Feb 20 18:03:43 2025 +0000

    Bump github.com/go-playground/validator/v10 from 10.24.0 to 10.25.0 (#512)

    Bumps [github.com/go-playground/validator/v10](https://github.com/go-playground/validator) from 10.24.0 to 10.25.0.
    - [Release notes](https://github.com/go-playground/validator/releases)
    - [Commits](go-playground/validator@v10.24.0...v10.25.0)

    ---
    updated-dependencies:
    - dependency-name: github.com/go-playground/validator/v10
      dependency-type: direct:production
      update-type: version-update:semver-minor
    ...

    Signed-off-by: dependabot[bot] <[email protected]>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

commit b61ec79
Author: Suma Naidu <[email protected]>
Date:   Thu Feb 20 09:03:25 2025 -0800

    Update readme with information about queue pause config

commit 0089095
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Thu Feb 20 15:49:46 2025 +0000

    Bump github.com/jedib0t/go-pretty/v6 from 6.6.5 to 6.6.6 (#511)

    Bumps [github.com/jedib0t/go-pretty/v6](https://github.com/jedib0t/go-pretty) from 6.6.5 to 6.6.6.
    - [Release notes](https://github.com/jedib0t/go-pretty/releases)
    - [Commits](jedib0t/go-pretty@v6.6.5...v6.6.6)

    ---
    updated-dependencies:
    - dependency-name: github.com/jedib0t/go-pretty/v6
      dependency-type: direct:production
      update-type: version-update:semver-patch
    ...

    Signed-off-by: dependabot[bot] <[email protected]>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

commit a22ecef
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Thu Feb 20 15:32:49 2025 +0000

    Bump github.com/buildkite/agent/v3 from 3.91.0 to 3.92.1 (#510)

    Bumps [github.com/buildkite/agent/v3](https://github.com/buildkite/agent) from 3.91.0 to 3.92.1.
    - [Release notes](https://github.com/buildkite/agent/releases)
    - [Changelog](https://github.com/buildkite/agent/blob/main/CHANGELOG.md)
    - [Commits](buildkite/agent@v3.91.0...v3.92.1)

    ---
    updated-dependencies:
    - dependency-name: github.com/buildkite/agent/v3
      dependency-type: direct:production
      update-type: version-update:semver-minor
    ...

    Signed-off-by: dependabot[bot] <[email protected]>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

commit 28f083b
Merge: 0c0982c bb58b97
Author: Josh Deprez <[email protected]>
Date:   Thu Feb 20 11:51:45 2025 +1100

    Merge pull request #449 from buildkite/option-to-allow-podspecpatch-cmd-mod

    Add config option to disable command modification check

commit bb58b97
Author: Josh Deprez <[email protected]>
Date:   Wed Dec 11 18:02:28 2024 +1100

    Add config option to disable command modification check

commit 0c0982c
Merge: ae2e95a 6577f93
Author: Pete Tomasik <[email protected]>
Date:   Wed Feb 19 12:41:35 2025 -0500

    Merge pull request #517 from buildkite/fix/job-failures-with-activedeadlineseconds

    Account for reason `DeadlineExceeded` in `checkFinishedWithoutPod()`

commit ae2e95a
Merge: ca2fb2d 0d3ddb8
Author: Pete Tomasik <[email protected]>
Date:   Wed Feb 19 12:40:19 2025 -0500

    Merge pull request #519 from mikehw/mikehw/annotate-pods-with-priority

    Annotate pods with job priority number

commit 0d3ddb8
Author: Mike White <[email protected]>
Date:   Wed Feb 19 08:55:02 2025 -0600

    Annotate pods with job priority number

commit ca2fb2d
Merge: 14ce89b ca30fae
Author: Pete Tomasik <[email protected]>
Date:   Wed Feb 19 08:48:45 2025 -0500

    Merge pull request #507 from buildkite/SUP-3361-handle-paused-queues

    [SUP-3361] Controller to handle queue paused events and prevent processing jobs

commit ca30fae
Author: nsuma <[email protected]>
Date:   Wed Feb 12 14:53:53 2025 -0800

    Controller to handle queue paused events and prevent processing jobs

commit 6577f93
Author: Pete Tomasik <[email protected]>
Date:   Tue Feb 18 15:32:31 2025 -0500

    Don't fail jobs that have reason DeadlineExceeded

commit 14ce89b
Merge: 94f0351 1b01857
Author: Pete Tomasik <[email protected]>
Date:   Tue Feb 18 13:57:24 2025 -0500

    Merge pull request #516 from buildkite/deps/test-latest-genqlient

    Bump github.com/Khan/genqlient from 0.7.0 to 0.8.0

commit 1b01857
Author: Pete Tomasik <[email protected]>
Date:   Tue Feb 18 09:22:30 2025 -0500

    genqlient upgrade, 0.7.0 to 0.8.0

commit 4b696c8
Author: Pete Tomasik <[email protected]>
Date:   Tue Feb 18 09:19:54 2025 -0500

    v0.7.0 re-install

commit 94f0351
Merge: aa21a0d 1a9ff14
Author: Pete Tomasik <[email protected]>
Date:   Tue Feb 18 09:15:03 2025 -0500

    Merge pull request #493 from buildkite/dependabot/go_modules/github.com/spf13/pflag-1.0.6

    Bump github.com/spf13/pflag from 1.0.5 to 1.0.6

commit aa21a0d
Merge: ede7471 d4dce26
Author: Pete Tomasik <[email protected]>
Date:   Tue Feb 18 09:11:34 2025 -0500

    Merge pull request #509 from buildkite/dependabot/go_modules/k8s-543119e5c9

    Bump the k8s group with 4 updates

commit ede7471
Merge: da7fae6 ce87e91
Author: Karen Sawrey <[email protected]>
Date:   Mon Feb 17 19:07:31 2025 +0200

    Merge pull request #514 from buildkite/SUP-3377

    Update CODEOWNERS

commit ce87e91
Author: Karen Sawrey <[email protected]>
Date:   Mon Feb 17 15:03:04 2025 +0100

    Update CODEOWNERS

    Codeowners team name change. Yes, again. Sorry, @DrJosh9000.

commit d4dce26
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Mon Feb 17 08:38:28 2025 +0000

    Bump the k8s group with 4 updates

    Bumps the k8s group with 4 updates: [k8s.io/api](https://github.com/kubernetes/api), [k8s.io/apimachinery](https://github.com/kubernetes/apimachinery), [k8s.io/client-go](https://github.com/kubernetes/client-go) and [sigs.k8s.io/controller-runtime](https://github.com/kubernetes-sigs/controller-runtime).

    Updates `k8s.io/api` from 0.32.1 to 0.32.2
    - [Commits](kubernetes/api@v0.32.1...v0.32.2)

    Updates `k8s.io/apimachinery` from 0.32.1 to 0.32.2
    - [Commits](kubernetes/apimachinery@v0.32.1...v0.32.2)

    Updates `k8s.io/client-go` from 0.32.1 to 0.32.2
    - [Changelog](https://github.com/kubernetes/client-go/blob/master/CHANGELOG.md)
    - [Commits](kubernetes/client-go@v0.32.1...v0.32.2)

    Updates `sigs.k8s.io/controller-runtime` from 0.20.1 to 0.20.2
    - [Release notes](https://github.com/kubernetes-sigs/controller-runtime/releases)
    - [Changelog](https://github.com/kubernetes-sigs/controller-runtime/blob/main/RELEASE.md)
    - [Commits](kubernetes-sigs/controller-runtime@v0.20.1...v0.20.2)

    ---
    updated-dependencies:
    - dependency-name: k8s.io/api
      dependency-type: direct:production
      update-type: version-update:semver-patch
      dependency-group: k8s
    - dependency-name: k8s.io/apimachinery
      dependency-type: direct:production
      update-type: version-update:semver-patch
      dependency-group: k8s
    - dependency-name: k8s.io/client-go
      dependency-type: direct:production
      update-type: version-update:semver-patch
      dependency-group: k8s
    - dependency-name: sigs.k8s.io/controller-runtime
      dependency-type: direct:production
      update-type: version-update:semver-patch
      dependency-group: k8s
    ...

    Signed-off-by: dependabot[bot] <[email protected]>

commit da7fae6
Merge: 835cc76 b529bab
Author: Josh Deprez <[email protected]>
Date:   Fri Feb 14 07:06:29 2025 +1100

    Merge pull request #508 from buildkite/sup-3255-imagecheckpullpolicy-gets-overriden-by-imagepullpolicy-issue

commit 835cc76
Merge: 3b466a7 7a13241
Author: Pete Tomasik <[email protected]>
Date:   Thu Feb 13 09:00:13 2025 -0500

    Merge pull request #497 from buildkite/SUP-3258-job-active-deadline-seconds

    SUP-3258 - Implement .spec.job.activeDeadlineSeconds

commit b529bab
Author: Josh Deprez <[email protected]>
Date:   Thu Feb 13 13:39:33 2025 +1100

    Fix unusable image pull policy options

commit 7a13241
Author: Pete Tomasik <[email protected]>
Date:   Wed Feb 12 16:59:55 2025 -0500

    Add test for activeDeadlineSeconds override, exceeded

commit b8801b4
Author: Pete Tomasik <[email protected]>
Date:   Wed Feb 12 16:59:12 2025 -0500

    Implement job.spec.activeDeadlineSeconds, default to 6h

commit 1a9ff14
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Mon Feb 3 08:24:16 2025 +0000

    Bump github.com/spf13/pflag from 1.0.5 to 1.0.6

    Bumps [github.com/spf13/pflag](https://github.com/spf13/pflag) from 1.0.5 to 1.0.6.
    - [Release notes](https://github.com/spf13/pflag/releases)
    - [Commits](spf13/pflag@v1.0.5...v1.0.6)

    ---
    updated-dependencies:
    - dependency-name: github.com/spf13/pflag
      dependency-type: direct:production
      update-type: version-update:semver-patch
    ...

    Signed-off-by: dependabot[bot] <[email protected]>

Signed-off-by: Tom Watt <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ImageCheckPullPolicy gets overriden by ImagePullPolicy
2 participants