enable name overrides #490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rayalan
approved these changes
Jan 30, 2025
DrJosh9000
requested changes
Feb 4, 2025
|
Thanks for the suggestions @DrJosh9000 . I've made the requisite changes to the chart. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This simple change will allow you to assert a new chart name for the helm installation. It does not introduce any regressions with the normal behavior of the chart.
Reasoning
I found a need for this while trying to deploy multiple Buildkite queues with the same parent chart. I essentially made a parent that calls this chart (n) times as a subchart dependency. This allows me to manage multiple queues with wildly different configurations without managing individual charts.
If requested, I'd be happy to provide a readme example for my specific use case.