fix(android): Parse java exception name when message missing #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kattrali
force-pushed
the
kattrali/read-android-java-class-without-message
branch
from
f82a87d to
3b080d0
Compare
tomlongridge
reviewed
Jul 3, 2019
kattrali
force-pushed
the
kattrali/read-android-java-class-without-message
branch
from
3b080d0 to
a1578f0
Compare
Not all Java exceptions have messages, so the default should be to set the class and java exception parsing style if the error class is detected.
kattrali
force-pushed
the
kattrali/read-android-java-class-without-message
branch
from
a1578f0 to
518e2e9
Compare
|
Updated with some additional comments around how Android Java exceptions are passed through the Unity log handler. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not all Java exceptions have messages, so the default should be to set the class and java exception parsing style if the Android error class is detected.
Depends on bugsnag/bugsnag-android#511