This repository has been archived by the owner on Dec 4, 2018. It is now read-only.
Better preparation for cloned object serialization #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When Utils.cloneObject() was called on an instance of a class,
such as the mongo driver's `ObjectId` instance, the copy would
bring across its enumerable private properties, but none of its
methods, resulting in a bad serialization like so:
"id": {
"id": {
"0": 88,
"1": 129,
"2": 222,
"3": 117,
"4": 187,
"5": 221,
"6": 189,
"7": 57,
"8": 86,
"9": 86,
"10": 65,
"11": 202
},
"bsontype": "ObjectID"
}
Now just before cloning, objects are checked for a toJSON() method.
If they have one, the result of that is used for the clone resulting
in better serialization, such as:
{ "oid": "5a9045f5be123c8c5d811d35" }
kattrali
approved these changes
Feb 23, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
Utils.cloneObject()was called on an instance of a class, such as the mongo driver'sObjectIdinstance, the copy would bring across its enumerable private properties, but none of its methods, resulting in a bad serialization like so:Now just before cloning, objects are checked for a toJSON() method. If they have one, the result of that is used for the clone resulting in better serialization, such as: