src/bugsnag: implement own polyfilling for requestAnimationFrame #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #72 (`requestAnimationFrame` wrapper doesn't honor the passed timestamp) The old approach rely on `hijackTimeFunc`, which expects a callback to accept at least two arguments. If the function being wrapped accepts only argument, it is being swallowed.
| } | ||
| }; | ||
| }); | ||
|
|
There was a problem hiding this comment.
Correctly me if I'm wrong, but I think the following is the equivalent, but much less code;
polyFill(window, "requestAnimationFrame", function (_super) {
return function (callback) {
if (typeof callback === "function") {
callback = wrap(callback);
}
return _super(callback);
};
});Thanks-to: Jacob Marshall
kyrylo
force-pushed
the
72-fix-requestanimframe
branch
from
9c4a19a to
88b31be
Compare
kattrali
pushed a commit
that referenced
this pull request
Apr 22, 2021
Upload cucumber failure logs when tests fail
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #72 (
requestAnimationFramewrapper doesn't honor the passedtimestamp)
The old approach rely on
hijackTimeFunc, which expects a callback toaccept at least two arguments. If the function being wrapped accepts
only argument, it is being swallowed.
Tested manually on IE 6,7,8,9,10, and modern Chrome.