Support IE 9 and lower better #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Although it is already supported, the problem is that the back-end expects 2 extra metaframes, if a stack trace was generated by us. The first approach in `generateStacktrace()` provides these frames, but if it fails, we fall back to the second approach, which lacks them. It means that on the back-end side the parser chops off two important frames.
| }; | ||
| window.postMessage("hello", "*"); | ||
| }); | ||
| } |
There was a problem hiding this comment.
@kyrylo can you please add an } else { it("should pass", function() {}) to this. That way the counts match on all browsers so it's easy to tell whether a browser has finished running the tests.
The problem with the previous test was that IE8 and lower don't run it, because of the "addEventListener" check.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although it is already supported, the problem is that the back-end
expects 2 extra metaframes, if a stack trace was generated by us.
The first approach in
generateStacktrace()provides these frames,but if it fails, we fall back to the second approach, which lacks
them. It means that on the back-end side the parser chops off two
important frames.