Fix internal type definition for session delegates #1480
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
The internal type definition for session delegates was wrong in a few ways:
startSession
returnedany
when it should always return a clientpauseSession
took no parameters when it actually takes a clientresumeSession
took no parameters and returned void when it actually takes and returns a clientThis can be verified by checking the session implementations:
plugin-browser-session
(plugin-electron-session
uses this implementation internally)plugin-react-native-session
plugin-server-session
There are no BC concerns here as we don't ship this type definition file in the NPM package, it's purely used internally:
bugsnag-js/packages/core/package.json
Lines 15 to 19 in ce9d8dc