Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix internal type definition for session delegates #1480

Merged
merged 1 commit into from
Jul 19, 2021

Conversation

imjoehaines
Copy link
Contributor

@imjoehaines imjoehaines commented Jul 19, 2021

Goal

The internal type definition for session delegates was wrong in a few ways:

  • startSession returned any when it should always return a client
  • pauseSession took no parameters when it actually takes a client
  • resumeSession took no parameters and returned void when it actually takes and returns a client

This can be verified by checking the session implementations:

There are no BC concerns here as we don't ship this type definition file in the NPM package, it's purely used internally:

"files": [
"lib",
"types",
"*.js"
],

@imjoehaines imjoehaines requested a review from tomlongridge July 19, 2021 14:54
@github-actions
Copy link

@bugsnag/browser bundle size diff

Minified Minfied + Gzipped
Before 41.24 kB 12.71 kB
After 41.24 kB 12.71 kB
± No change No change

code coverage diff

Coverage values did not change👌.

Total:

Lines Branches Functions Statements
0%(+0%) 0%(+0%) 0%(+0%) 0%(+0%)

Generated by 🚫 dangerJS against ce9d8dc

@imjoehaines imjoehaines merged commit 577bc44 into next Jul 19, 2021
@imjoehaines imjoehaines deleted the fix-internal-types branch July 19, 2021 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants