feat(electron): Use page title/window location for default context in renderers #1402
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Renderer events should have a default context.
Design
This implementation takes the page title, and falls back to the window location.
Changeset
Since the amount of logic required was so small I felt comfortable augmenting the renderer event data plugin, rather than creating an entire new plugin.
For packaged apps,
window.location.pathname
is an absolute file path (like stacktraces). I tweaked logic for stackframe project root stripping so it could be referenced from the renderer event plugin rather than duplicated.Testing
End to end tests added for all the cases I could think of.
config.context
andsetContext()
should take precedence.