Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Xcode 12 to build react-native 0.63 #1390

Merged
merged 6 commits into from
May 11, 2021
Merged

Use Xcode 12 to build react-native 0.63 #1390

merged 6 commits into from
May 11, 2021

Conversation

Cawllec
Copy link
Contributor

@Cawllec Cawllec commented May 6, 2021

Goal

Updates chosen buildkite queues to build React-native 0.63 test fixtures using Xcode 12, testing that going forward.

In addition, removes package-lock from test fixture as this could potentially cause issues building on different test boxes.

@github-actions
Copy link

github-actions bot commented May 6, 2021

@bugsnag/browser bundle size diff

Minified Minfied + Gzipped
Before 40.86 kB 12.61 kB
After 40.86 kB 12.61 kB
± No change No change

code coverage diff

Coverage values did not change👌.

Total:

Lines Branches Functions Statements
0%(+0%) 0%(+0%) 0%(+0%) 0%(+0%)

Generated by 🚫 dangerJS against 36808fc

@Cawllec Cawllec merged commit 6d36dff into next May 11, 2021
@nickdowell nickdowell deleted the tests/react-native-xcode-12 branch January 4, 2022 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bengourley bengourley bengourley approved these changes

@twometresteve twometresteve Awaiting requested review from twometresteve

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Cawllec @bengourley