-
Notifications
You must be signed in to change notification settings - Fork 255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Electron: refactor app version fields #1389
Electron: refactor app version fields #1389
Conversation
Prevent issues with long file names on windows.
|
Minified | Minfied + Gzipped | |
---|---|---|
Before | 40.87 kB |
12.62 kB |
After | 40.87 kB |
12.62 kB |
± | No change | No change |
code coverage diff
Ok | File | Lines | Branches | Functions | Statements |
---|---|---|---|---|---|
🔴 | /home/runner/work/bugsnag-js/bugsnag-js/packages/electron/src/config/renderer.js | 20.59% (-1.29%) |
0% (+0%) |
0% (+0%) |
20% (-1.21%) |
🔴 | /home/runner/work/bugsnag-js/bugsnag-js/packages/plugin-electron-app/app.js | 100% (+0%) |
87.5% (-4.5%) |
100% (+0%) |
100% (+0%) |
Total:
Lines | Branches | Functions | Statements |
---|---|---|---|
82.47%(-0.03%) | 72.07%(-0.14%) | 83.36%(-0.14%) | 81.46%(-0.03%) |
As I understand it, we are also dropping |
|
appVersion
codeBundleId
can now be set in renderer config and is included in the payload for renderer events