Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Electron: refactor app version fields #1389

Merged

Conversation

bengourley
Copy link
Contributor

  • native package version is now the default for appVersion
  • codeBundleId can now be set in renderer config and is included in the payload for renderer events

@bengourley bengourley requested a review from imjoehaines May 6, 2021 13:09
@github-actions
Copy link

github-actions bot commented May 6, 2021

@bugsnag/browser bundle size diff

Minified Minfied + Gzipped
Before 40.87 kB 12.62 kB
After 40.87 kB 12.62 kB
± No change No change

code coverage diff

Ok File Lines Branches Functions Statements
🔴 /home/runner/work/bugsnag-js/bugsnag-js/packages/electron/src/config/renderer.js 20.59%
(-1.29%)
0%
(+0%)
0%
(+0%)
20%
(-1.21%)
🔴 /home/runner/work/bugsnag-js/bugsnag-js/packages/plugin-electron-app/app.js 100%
(+0%)
87.5%
(-4.5%)
100%
(+0%)
100%
(+0%)

Total:

Lines Branches Functions Statements
82.47%(-0.03%) 72.07%(-0.14%) 83.36%(-0.14%) 81.46%(-0.03%)

Generated by 🚫 dangerJS against 281d7d3

@tomlongridge
Copy link
Contributor

As I understand it, we are also dropping bundleVersion and reporting new a new metadata.app.CFBundleVersion instead. Is that planned under a separate PR?

@bengourley
Copy link
Contributor Author

bengourley commented May 6, 2021

As I understand it, we are also dropping bundleVersion

bundleVersion was removed here https://github.com/bugsnag/bugsnag-js/pull/1389/files#diff-b9305f224b4d7de52d1f1b05b2740104d49f53cf977f72be6d57df5c7b37eceeL61

reporting new a new metadata.app.CFBundleVersion instead. Is that planned under a separate PR

CFBundleVersion is what the native_package_version logic uses.

@imjoehaines imjoehaines merged commit 1a85bd5 into kattrali/add-electron-support May 7, 2021
@imjoehaines imjoehaines deleted the bengourley/electron-app-version branch May 7, 2021 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants