ci: run electron runner tests on GH actions #1373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The other unit test configuration is alpine-based, which uses musl libc and is currently incompatible with running electron
|
| Minified | Minfied + Gzipped | |
|---|---|---|
| Before | 40.87 kB |
12.62 kB |
| After | 40.87 kB |
12.62 kB |
| ± | No change | No change |
code coverage diff
Coverage values did not change👌.
Total:
| Lines | Branches | Functions | Statements |
|---|---|---|---|
| 82.55%(+7.12%) | 72.27%(+0.54%) | 83.48%(+9.02%) | 81.54%(+6.83%) |
|
oh shucks. I broke coverage bot because the |
Base automatically changed from
bengourley/electron-ci-improvements
to
kattrali/add-electron-support
April 29, 2021 08:44
kattrali
force-pushed
the
kattrali/electron-runner-gh-actions
branch
from
7581df3 to
2fdb839
Compare
kattrali
force-pushed
the
kattrali/electron-runner-gh-actions
branch
from
a692964 to
e85dc4a
Compare
kattrali
force-pushed
the
kattrali/electron-runner-gh-actions
branch
from
e85dc4a to
0fa5700
Compare
bengourley
approved these changes
May 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The other unit test configuration is alpine-based, which uses musl libc and is currently incompatible with running electron
Testing