-
Notifications
You must be signed in to change notification settings - Fork 255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
React Native tests with pre-release native notifiers #1367
Conversation
7157887
to
34ccbf9
Compare
The logic LGTM, but I find |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree with Nick's comment about the env var name. Also a question about repeated builds/caching to avoid building exactly the same release more than once.
Otherwise LGTM.
Changing to |
34ccbf9
to
066497b
Compare
Goal
Provides a mechanism for running integration test of the React Native notifier, using the pre-release Android and Cocoa notifiers from their respective
next
branches.Design
The
RN_INTEGRATION
build environment variable can be set (to "true") either on a Buildkite schedule, trigger step, or when creating a build manually. If set, the pipeline will pull in and build the latestnext
version of bugsnag-android and bugsnag-cocoa before publishing the notifier. It will then run only the React Native e2e tests.If run in this mode, the version for the published notifier is based on the current timestamp, rather than the current commit Id of bugsnag-js. Publishing is skipped if the same version is used as a previous build and even though bugsnag-js may not have changed, the native notifier may have.
An improvement to the current would be to somehow build in a check that the latest native notifiers really have been build in, but I couldn't think of a way to achieve that.
Testing
Covered by CI and inspection of the logs. I've also run it three times via a schedule.