[PLAT-6128] RN-CLI: Use a more exhaustive search for MainApplication.java #1365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ion.java Ejected Expo projects have a different directory structure to RN projects generated with the RN CLI. This update uses the glob package to determine the location of MainApplication.java no matter where it exists within the app directory.
|
| Minified | Minfied + Gzipped | |
|---|---|---|
| Before | 40.86 kB |
12.61 kB |
| After | 40.86 kB |
12.61 kB |
| ± | No change | No change |
code coverage diff
Coverage values did not change👌.
Total:
| Lines | Branches | Functions | Statements |
|---|---|---|---|
| 81.47%(-0.01%) | 70.42%(+0%) | 84.01%(+0%) | 80.39%(+0%) |
bengourley
commented
Apr 22, 2021
bengourley
force-pushed
the
bengourley/rn-cli-main-application-search
branch
from
a879c0d to
c3a630d
Compare
bengourley
force-pushed
the
bengourley/rn-cli-main-application-search
branch
from
ce5f737 to
25ffde7
Compare
bengourley
force-pushed
the
bengourley/rn-cli-main-application-search
branch
from
5da5b49 to
01e09c4
Compare
bengourley
force-pushed
the
bengourley/rn-cli-main-application-search
branch
from
259b089 to
f827015
Compare
imjoehaines
approved these changes
Apr 27, 2021
Co-authored-by: Joe Haines <[email protected]>
…m:bugsnag/bugsnag-js into bengourley/rn-cli-main-application-search
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ejected Expo projects have a different directory structure to RN projects generated with the RN CLI. This update uses the glob package to determine the location of MainApplication.java no matter where it exists within the app directory.
Goal
Ensure the CLI works with the default directory structure of an ejected Expo app.
Design
The
globmodule was added to recursively search the app directory forMainApplication.java. This means the CLI can cope with various directory structures.Changeset
globdependencyTesting
Relying on updated unit tests and existing automated tests.
As well as catching regressions on the existing fixture apps, I'm currently adding a new ejected Expo fixture to the automated tests to determine that the updated logic does works as intended.