Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add trackInlineScripts to BrowserConfig #1097

Closed
wants to merge 1 commit into from

Conversation

blimmer
Copy link
Contributor

@blimmer blimmer commented Oct 12, 2020

Goal

trackInlineScripts is supported on the browser and should be reflected in the TypeScript types (docs), but is not represented in the .d.ts file.

Design

This pattern matches all the other "browser only" configuration options.

Changeset

Added trackInlineScripts to BrowserConfig.

Testing

N/A, just a TypeScript definition.

`trackInlineScripts` is supported on the browser and should be reflected in the TypeScript types ([docs](https://docs.bugsnag.com/platforms/javascript/configuration-options/#trackinlinescripts-browser-only)).
@xljones
Copy link

xljones commented Oct 13, 2020

Thanks @blimmer, we'll take a look into this.

@xljones xljones added backlog We hope to fix this feature/bug in the future bug Confirmed bug labels Oct 13, 2020
@blimmer
Copy link
Contributor Author

blimmer commented Oct 14, 2020

Thanks @xander-jones. I noticed the backlog tag got added, which looks like it's used primarily on issues. Just a heads up that this is a PR that fixes the problem 😄

@xljones
Copy link

xljones commented Oct 15, 2020

Our backlog tag is used to signify issues & PRs which we're going to be taking a look into. No worries though, we know it's a PR 😄 . There are a few additional tasks that we need to do beyond merging so we use this tag to help track which ones we need to work on.

@bengourley
Copy link
Contributor

Thanks @blimmer. In order to get the tests to run on our private infrasctructure, I've opened up #1102. This includes your changes and a small addition to the tests.

Closing in favour of #1102.

@bengourley bengourley closed this Oct 19, 2020
@bengourley bengourley mentioned this pull request Oct 22, 2020
@xljones
Copy link

xljones commented Oct 26, 2020

Hey @blimmer, this has been added in https://github.com/bugsnag/bugsnag-js/releases/tag/v7.5.1

@xljones xljones added released This feature/bug fix has been released and removed backlog We hope to fix this feature/bug in the future labels Oct 26, 2020
@blimmer
Copy link
Contributor Author

blimmer commented Oct 26, 2020

Thank you for the mention!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Confirmed bug released This feature/bug fix has been released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants