Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ProjectPackages should allow subpackages #23

Closed
levinalex opened this issue Oct 5, 2015 · 3 comments
Closed

ProjectPackages should allow subpackages #23

levinalex opened this issue Oct 5, 2015 · 3 comments

Comments

@levinalex
Copy link

right now ProjectPackages uses filepath.Match to check which parts of the stacktrace to filter:

bugsnag.Configure(bugsnag.Configuration{
    ProjectPackages: []string{"main", "example.com/foo/*"},
}

However, wildcards (because of Filepath.match) will only be expanded into a single 'directory'. This matches example.com/foo/bar and example.com/foo/baz but not example.com/foo/bar/fred or example.com/foo/bar/fred/bar.

(my workaround to that was to say {"example.com/foo/*", example.com/foo/*/*", example.com/foo/*/*/*"} but that is brittle and ugly)

It would be nice if it was possible to match all subpackages explicitly (maybe via "example.com/foo/**"?)

I'd take a stab at implementing this if you are open to it

@snmaynard
Copy link
Contributor

Hey @levinalex - this seems like it would be a solid addition to the library. If you want to take a stab at it that would be great. If not then someone will get around to this soon!

fjferrer added a commit to fjferrer/bugsnag-go that referenced this issue Nov 9, 2015
kattrali added a commit that referenced this issue Nov 17, 2015
This pull request fix the issue #23
@kattrali
Copy link
Contributor

Fixed by #25. Thanks!

@levinalex
Copy link
Author

thank you 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants