Populate app/device metadata fields for RN errors #763

fractalwrench · 2020-07-23T11:46:56Z

Goal

Fixes the population of the following app/device metadata fields in RN errors:

app.name
device.batteryLevel
device.charging
device.simulator
device.timezone
device.wordsize

This changeset comes in two parts:

Performing an initial sync of metadata whenever a state event observer is added. This allows the JS layer on React Native to pass down the stateless fields in metadata.
Always adding stateful device metadata fields when notifyInternal is called.

Verified in a local example app that the fields are populated.

Bugsnag/Client/BugsnagClient.m

$fractalwrench$

$@fractalwrench$

fix: populate app/device metadata fields for RN errors

4b09b69

$@fractalwrench$ fractalwrench force-pushed the v7rn-app-device-population branch from c693f21 to 4b09b69 Compare July 23, 2020 11:47

$@fractalwrench$ fractalwrench requested a review from tomlongridge July 23, 2020 13:00

$@fractalwrench$

fix: move notifyobservers call to correct method

febf1a7

tomlongridge reviewed Jul 23, 2020

View reviewed changes

Bugsnag/Client/BugsnagClient.m Outdated Show resolved Hide resolved

$@fractalwrench$

address review feedback

b61f227

$@fractalwrench$ fractalwrench requested a review from tomlongridge July 23, 2020 13:35

tomlongridge approved these changes Jul 23, 2020

View reviewed changes

$@fractalwrench$ fractalwrench merged commit fe46699 into react-native-plugin Jul 23, 2020

$@fractalwrench$ fractalwrench deleted the v7rn-app-device-population branch July 23, 2020 15:14