Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove cpp extension from podspec #598

Closed
wants to merge 1 commit into from
Closed

Remove cpp extension from podspec #598

wants to merge 1 commit into from

Conversation

keith
Copy link
Contributor

@keith keith commented May 13, 2020

There are no *.cpp in this project.

@keith
Remove cpp extension from podspec
947888c 
There are no `*.cpp` in this project.
@mattdyoung
Copy link

Thanks @keith! We'll look at reviewing and merging.

@robinmacharg robinmacharg mentioned this pull request May 27, 2020
Merged
@robinmacharg
Copy link
Contributor

Thanks for spotting this, @keith; we appreciate your attention to detail. I've rolled the change into our work on v6 of the notifier, linked to in #633, above.

@keith keith deleted the ks/remove-cpp-extension-from-podspec branch May 29, 2020 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@keith @mattdyoung @robinmacharg