Make all callbacks return boolean values #534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fractalwrench
changed the title
fractalwrench
force-pushed
the
v6-blocks
branch
from
f11941c to
194bf0c
Compare
robinmacharg
suggested changes
Apr 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Updates the
OnSendBlockandOnSessionBlockcallbacks to return boolean values which control whether the event/session is sent or not.Changeset
BOOLfor both callback typesOnSessionBlockcallbacks into theSessionTracker. If a callback returns false, the new session is discarded and the original session (if any) is usedNote: the session callback is effectively passed an empty dictionary as its parameter for now, which has been noted as a TODO comment. Future work has been scheduled which will alter the parameter to take a structured class with session information instead.
Tests
Added new unit tests to verify the behaviour for session blocks.