[PLAT-8318] Fix inaccurate isPC & isLR values #1470
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Improve the accuracy of
isPC
andisLR
stackframe values which are used by the back-end to determine how to symbolicateframeAddress
.Changeset
Examines the register values captured by KSCrash to compute
isPC
andisLR
values in+[BugsnagThread enhanceThreadInfo:]
.Switches to using the
BSG_KSCrashField_*
keys inBugsnagStackframe.m
.Improves header documentation in
BugsnagStackframe.h
.Testing
Amends existing unit tests to verify
isPC
andisLR
are set when expected.Amends existing E2E scenarios to verify
isPC
andisLR
.