Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PLAT-8680] ordered feature flags #1429

Merged
merged 1 commit into from
Jul 8, 2022
Merged

Conversation

kstenerud
Copy link
Contributor

Goal

Keep feature flags in the order they were added or modified.

Design

Change the internal representation from a dictionary to an array.

Testing

Updated unit tests to verify ordering.

@kstenerud kstenerud force-pushed the PLAT-8680-ordered-feature-flags branch from 9dfc429 to 1c54a0c Compare July 8, 2022 11:52
@github-actions
Copy link

github-actions bot commented Jul 8, 2022

Bugsnag.framework binary size decreased by 128 bytes from 815,960 to 815,832 🎉

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  +1.2%    +242  +1.2%    +242    [__TEXT]
  [ = ]       0  +4.0%    +128    [__LINKEDIT]
  +0.5%     +40  +0.3%     +40    [__DATA]
  +0.0%     +24  +0.0%     +24    __DATA,__objc_const
  +0.0%     +16  +0.0%     +16    Symbol Table
  -0.4%      -8  -0.4%      -8    Rebase Info
  -0.0%     -10  -0.0%     -10    __TEXT,__objc_methname
  -0.2%     -40  -0.2%     -40    __TEXT,__cstring
  -1.1%     -40  -1.1%     -40    __TEXT,__gcc_except_tab
  -1.8%     -64  -1.8%     -64    __DATA,__const
  -0.1%    -136  -0.1%    -136    String Table
  -0.1%    -152  -0.1%    -152    __TEXT,__text
  -0.0%    -128  [ = ]       0    TOTAL

Generated by 🚫 Danger

@kstenerud kstenerud force-pushed the PLAT-8680-ordered-feature-flags branch from 1c54a0c to dcc5aea Compare July 8, 2022 12:04
@kstenerud kstenerud marked this pull request as ready for review July 8, 2022 12:33
@kstenerud kstenerud requested review from nickdowell and kattrali July 8, 2022 12:33
@kstenerud kstenerud merged commit fa7abec into next Jul 8, 2022
@kstenerud kstenerud deleted the PLAT-8680-ordered-feature-flags branch July 8, 2022 12:50
@nickdowell nickdowell mentioned this pull request Jul 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants