Disable file protection for BSGRunContext #1407
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Fix a potential segfault when accessing
bsg_runContext
after device is locked.If an app uses the Data Protection Entitlement to set the default protection to
NSFileProtectionComplete
, the file mapping becomes invalidated once the underlying file gets encrypted - i.e. after locking the device. Dereferencingbsg_runContext
then causes a segfault and crashes the app.Changeset
Disables content / file protection of the memory mapped file, using the NSURL / NSURLFileProtection APIs.
Considered using lower-level APIs -
fcntl
withF_GETPROTECTIONCLASS
andF_SETPROTECTIONCLASS
is available but the protection class definitions are private to xnu and their mappings to corresponding NSURLFileProtectionType undocumented.Testing
Reproduced the crash locally by adding the Data Protection Entitlement and a UIBackgroundTask to a sample app. After locking the device, the app would crash upon completion of a 10s background task (it appears that content gets protected after a 10 second grace period.)
Was unable to reproduce the crash with this fix in place.