[PLAT-7656] Send sessions without requiring disk storage #1246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickdowell
force-pushed
the
nickdowell/session-delivery
branch
from
ad0a182 to
9ead29c
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
kstenerud
approved these changes
Dec 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Allow sessions to be sent without persisting to disk first, and only persist if the sending fails.
This makes session sending more resilient in the face of a full file system, and improves performance by avoiding file I/O on the main / calling thread.
Changeset
The changes may make more sense when viewed as individual commits, due to the refactoring
-uploadSession:to send the payload immediately and store to disk upon failureBugsnagSessionTrackingApiClienttoBSGSessionUploader(due to the number of changes the diff shows this as an addition and removal, but some original logic remains)BugsnagApiClientBugsnagSessionTrackingPayloadwith a dictionary literal that is much easier to understandTesting
This functionality is covered by existing E2E tests - verified locally and on CI