More robust jailbreak detection #1000
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kstenerud
force-pushed
the
5969-jailbreak-detection
branch
4 times, most recently
from
3559ecb to
7755e58
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
kstenerud
force-pushed
the
5969-jailbreak-detection
branch
3 times, most recently
from
212f05e to
30a3ec4
Compare
nickdowell
suggested changes
Feb 15, 2021
nickdowell
suggested changes
Feb 15, 2021
kstenerud
force-pushed
the
5969-jailbreak-detection
branch
from
30a3ec4 to
951a23d
Compare
kstenerud
force-pushed
the
5969-jailbreak-detection
branch
from
951a23d to
0ed6194
Compare
nickdowell
approved these changes
Feb 15, 2021
nickdowell
added a commit
that referenced
this pull request
Feb 24, 2021
This was referenced Mar 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal & Design
https://bugsnag.atlassian.net/wiki/spaces/EN/pages/1946321640/ROAD-989+Improve+Jailbroken+Detection+iOS
Changeset
Added
BSG_Jailbreak.h, and modifiedBSG_KSSystemInfoto use it.Although the high level
isJailbreakfunctionality is still susceptible to attack, the code that generates the JSON for the report is not, and that's the part we care about because it's what gets sent to the backend.Testing
Manual testing on jailbroken and non-jailbroken devices.