Merge pull request #1558 from bugsnag/release-v6.27.0

Release v6.27.0
bugsnag · May 15, 2023 · 7410780 · 7410780
2 parents c730af7 + 6f895b8
commit 7410780
Show file tree

Hide file tree

Showing 24 changed files with 125 additions and 92 deletions.
diff --git a/.buildkite/pipeline.full.yml b/.buildkite/pipeline.full.yml
@@ -199,7 +199,7 @@ steps:
         command:
           - "--app=/app/build/iOSTestApp.ipa"
           - "--farm=bb"
-          - "--device=IOS_13"
+          - "--device=IOS_12"
           - "--no-tunnel"
           - "--aws-public-ip"
           - "--fail-fast"
@@ -230,7 +230,7 @@ steps:
         command:
           - "--app=/app/build/iOSTestApp.ipa"
           - "--farm=bb"
-          - "--device=IOS_13"
+          - "--device=IOS_12"
           - "--no-tunnel"
           - "--aws-public-ip"
           - "--fail-fast"
@@ -270,7 +270,7 @@ steps:
           - "--fail-fast"
           - "--exclude=features/[e-z].*.feature$"
           - "--order=random"
-    concurrency: 24
+    concurrency: 5
     concurrency_group: browserstack-app
     concurrency_method: eager
     retry:
@@ -301,7 +301,7 @@ steps:
           - "--fail-fast"
           - "--exclude=features/[a-d].*.feature$"
           - "--order=random"
-    concurrency: 24
+    concurrency: 5
     concurrency_group: browserstack-app
     concurrency_method: eager
     retry:

diff --git a/.buildkite/pipeline.yml b/.buildkite/pipeline.yml
@@ -393,7 +393,7 @@ steps:
         command:
           - "--app=/app/build/iOSTestApp.ipa"
           - "--farm=bb"
-          - "--device=IOS_13"
+          - "--device=IOS_12"
           - "--no-tunnel"
           - "--aws-public-ip"
           - "--fail-fast"
@@ -430,7 +430,7 @@ steps:
           - "--fail-fast"
           - "--exclude=features/[e-z].*.feature$"
           - "--order=random"
-    concurrency: 24
+    concurrency: 5
     concurrency_group: browserstack-app
     concurrency_method: eager
     retry:
@@ -459,7 +459,7 @@ steps:
           - "--fail-fast"
           - "--exclude=features/[a-d].*.feature$"
           - "--order=random"
-    concurrency: 24
+    concurrency: 5
     concurrency_group: browserstack-app
     concurrency_method: eager
     retry:
@@ -486,7 +486,7 @@ steps:
           - "--device=IOS_11_0_IPHONE_8_PLUS"
           - "--appium-version=1.8.0"
           - "features/barebone_tests.feature"
-    concurrency: 24
+    concurrency: 5
     concurrency_group: browserstack-app
     concurrency_method: eager
     retry:
@@ -514,7 +514,7 @@ steps:
           - "--appium-version=1.8.0"
           - "--fail-fast"
           - "features/barebone_tests.feature"
-    concurrency: 24
+    concurrency: 5
     concurrency_group: browserstack-app
     concurrency_method: eager
     retry:

diff --git a/.jazzy.yaml b/.jazzy.yaml
@@ -2,11 +2,11 @@ author_url: "https://www.bugsnag.com"
 author: "Bugsnag Inc"
 clean: false # avoid deleting docs/.git
 framework_root: "Bugsnag"
-github_file_prefix: "https://github.com/bugsnag/bugsnag-cocoa/tree/v6.26.2/Bugsnag"
+github_file_prefix: "https://github.com/bugsnag/bugsnag-cocoa/tree/v6.27.0/Bugsnag"
 github_url: "https://github.com/bugsnag/bugsnag-cocoa"
 hide_documentation_coverage: true
 module: "Bugsnag"
-module_version: "6.26.2"
+module_version: "6.27.0"
 objc: true
 output: "docs"
 readme: "README.md"

diff --git a/Bugsnag.podspec.json b/Bugsnag.podspec.json
@@ -1,6 +1,6 @@
 {
   "name": "Bugsnag",
-  "version": "6.26.2",
+  "version": "6.27.0",
   "summary": "The Bugsnag crash reporting framework for Apple platforms.",
   "homepage": "https://bugsnag.com",
   "license": "MIT",
@@ -9,7 +9,7 @@
   },
   "source": {
     "git": "https://github.com/bugsnag/bugsnag-cocoa.git",
-    "tag": "v6.26.2"
+    "tag": "v6.27.0"
   },
   "ios": {
     "frameworks": [

diff --git a/Bugsnag/Client/BugsnagClient.m b/Bugsnag/Client/BugsnagClient.m
@@ -341,7 +341,7 @@ - (void)markLaunchCompleted {
 }
 
 - (void)sendLaunchCrashSynchronously {
-    if (self.configuration.session.delegateQueue == NSOperationQueue.currentQueue) {
+    if (self.configuration.sessionOrDefault.delegateQueue == NSOperationQueue.currentQueue) {
         bsg_log_warn(@"Cannot send launch crash synchronously because session.delegateQueue is set to the current queue.");
         return;
     }

diff --git a/Bugsnag/Configuration/BugsnagConfiguration+Private.h b/Bugsnag/Configuration/BugsnagConfiguration+Private.h
@@ -34,6 +34,8 @@ BSG_OBJC_DIRECT_MEMBERS
 
 @property (readonly, nonatomic) BOOL shouldSendReports;
 
+@property (readonly, nonnull, nonatomic) NSURLSession *sessionOrDefault;
+
 @property (readonly, nullable, nonatomic) NSURL *sessionURL;
 
 @property (readwrite, retain, nonnull, nonatomic) BugsnagUser *user;

diff --git a/Bugsnag/Configuration/BugsnagConfiguration.m b/Bugsnag/Configuration/BugsnagConfiguration.m
@@ -41,6 +41,18 @@
 
 static const int BSGApiKeyLength = 32;
 
+static NSURLSession *getConfigDefaultURLSession(void);
+static NSURLSession *getConfigDefaultURLSession(void) {
+    static dispatch_once_t once_t;
+    static NSURLSession *session;
+    dispatch_once(&once_t, ^{
+        session = [NSURLSession
+                    sessionWithConfiguration:[NSURLSessionConfiguration
+                                              defaultSessionConfiguration]];
+    });
+    return session;
+}
+
 // =============================================================================
 // MARK: - BugsnagConfiguration
 // =============================================================================
@@ -190,12 +202,6 @@ - (instancetype)initWithApiKey:(NSString *)apiKey {
     // persistUser isn't settable until post-init.
     _user = BSGGetPersistedUser();
 
-    if ([NSURLSession class]) {
-        _session = [NSURLSession
-            sessionWithConfiguration:[NSURLSessionConfiguration
-                                         defaultSessionConfiguration]];
-    }
-
     _telemetry = BSGTelemetryAll;
 
     NSString *releaseStage = nil;
@@ -273,6 +279,11 @@ - (void)setUser:(NSString *)userId withEmail:(NSString *)email andName:(NSString
     }
 }
 
+- (NSURLSession *)sessionOrDefault {
+    NSURLSession *session = self.session;
+    return session ? session : getConfigDefaultURLSession();
+}
+
 // =============================================================================
 // MARK: - onSendBlock
 // =============================================================================

diff --git a/Bugsnag/Delivery/BSGEventUploadOperation.m b/Bugsnag/Delivery/BSGEventUploadOperation.m
@@ -159,7 +159,7 @@ - (void)runWithDelegate:(id<BSGEventUploadOperationDelegate>)delegate completion
         }
     }
 
-    BSGPostJSONData(configuration.session, data, requestHeaders, notifyURL, ^(BSGDeliveryStatus status, __unused NSError *deliveryError) {
+    BSGPostJSONData(configuration.sessionOrDefault, data, requestHeaders, notifyURL, ^(BSGDeliveryStatus status, __unused NSError *deliveryError) {
         switch (status) {
             case BSGDeliveryStatusDelivered:
                 bsg_log_debug(@"Uploaded event %@", self.name);

diff --git a/Bugsnag/Delivery/BSGSessionUploader.m b/Bugsnag/Delivery/BSGSessionUploader.m
@@ -173,7 +173,7 @@ - (void)sendSession:(BugsnagSession *)session completionHandler:(nonnull void (^
         return;
     }
 
-    BSGPostJSONData(self.config.session, data, headers, url, ^(BSGDeliveryStatus status, NSError *error) {
+    BSGPostJSONData(self.config.sessionOrDefault, data, headers, url, ^(BSGDeliveryStatus status, NSError *error) {
         switch (status) {
             case BSGDeliveryStatusDelivered:
                 bsg_log_info(@"Sent session %@", session.id);

diff --git a/Bugsnag/Payload/BugsnagError.m b/Bugsnag/Payload/BugsnagError.m
@@ -23,6 +23,7 @@
 static BSGErrorTypeString const BSGErrorTypeStringCocoa = @"cocoa";
 static BSGErrorTypeString const BSGErrorTypeStringC = @"c";
 static BSGErrorTypeString const BSGErrorTypeStringReactNativeJs = @"reactnativejs";
+static BSGErrorTypeString const BSGErrorTypeStringCSharp = @"csharp";
 
 
 NSString *_Nonnull BSGSerializeErrorType(BSGErrorType errorType) {
@@ -33,6 +34,8 @@
             return BSGErrorTypeStringC;
         case BSGErrorTypeReactNativeJs:
             return BSGErrorTypeStringReactNativeJs;
+        case BSGErrorTypeCSharp:
+            return BSGErrorTypeStringCSharp;
     }
 }
 
@@ -43,6 +46,8 @@ BSGErrorType BSGParseErrorType(NSString *errorType) {
         return BSGErrorTypeC;
     } else if ([BSGErrorTypeStringReactNativeJs isEqualToString:errorType]) {
         return BSGErrorTypeReactNativeJs;
+    } else if ([BSGErrorTypeStringCSharp isEqualToString:errorType]) {
+        return BSGErrorTypeCSharp;
     } else {
         return BSGErrorTypeCocoa;
     }

diff --git a/Bugsnag/Payload/BugsnagNotifier.m b/Bugsnag/Payload/BugsnagNotifier.m
@@ -23,7 +23,7 @@ - (instancetype)init {
 #else
         _name = @"Bugsnag Objective-C";
 #endif
-        _version = @"6.26.2";
+        _version = @"6.27.0";
         _url = @"https://github.com/bugsnag/bugsnag-cocoa";
         _dependencies = @[];
     }

diff --git a/Bugsnag/include/Bugsnag/BugsnagError.h b/Bugsnag/include/Bugsnag/BugsnagError.h
@@ -18,7 +18,8 @@
 typedef NS_OPTIONS(NSUInteger, BSGErrorType) {
     BSGErrorTypeCocoa NS_SWIFT_NAME(cocoa), // Swift won't bring in the zeroeth option by default
     BSGErrorTypeC NS_SWIFT_NAME(c), // Fix Swift auto-capitalisation
-    BSGErrorTypeReactNativeJs
+    BSGErrorTypeReactNativeJs,
+    BSGErrorTypeCSharp,
 };
 
 /**

diff --git a/BugsnagNetworkRequestPlugin.podspec.json b/BugsnagNetworkRequestPlugin.podspec.json
@@ -1,16 +1,16 @@
 {
   "name": "BugsnagNetworkRequestPlugin",
-  "version": "6.26.2",
+  "version": "6.27.0",
   "summary": "Network request monitoring support for Bugsnag.",
   "homepage": "https://bugsnag.com",
   "license": "MIT",
   "authors": {
     "Bugsnag": "[email protected]"
   },
-  "readme": "https://raw.githubusercontent.com/bugsnag/bugsnag-cocoa/v6.26.2/BugsnagNetworkRequestPlugin/README.md",
+  "readme": "https://raw.githubusercontent.com/bugsnag/bugsnag-cocoa/v6.27.0/BugsnagNetworkRequestPlugin/README.md",
   "source": {
     "git": "https://github.com/bugsnag/bugsnag-cocoa.git",
-    "tag": "v6.26.2"
+    "tag": "v6.27.0"
   },
   "dependencies": {
     "Bugsnag": "~> 6.13"

diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,6 +1,18 @@
 Changelog
 =========
 
+## 6.27.0 (2023-05-15)
+
+### Enhancements
+
+* Added BSGErrorTypeCSharp enum value to identify C# events passed to the SDK
+  [1556](https://github.com/bugsnag/bugsnag-cocoa/pull/1556)
+
+### Bug fixes
+
+* Don't generate a new URLSession when copying a configuration.
+  [1554](https://github.com/bugsnag/bugsnag-cocoa/pull/1554)
+
 ## 6.26.2 (2023-04-20)
 
 ### Bug fixes

diff --git a/Framework/Info.plist b/Framework/Info.plist
@@ -15,7 +15,7 @@
 	<key>CFBundlePackageType</key>
 	<string>FMWK</string>
 	<key>CFBundleShortVersionString</key>
-	<string>6.26.2</string>
+	<string>6.27.0</string>
 	<key>CFBundleVersion</key>
 	<string>1</string>
 </dict>

diff --git a/Gemfile b/Gemfile
@@ -4,7 +4,7 @@ gem 'cocoapods'
 
 # A reference to Maze Runner is only needed for running tests locally and if committed it must be
 # portable for CI, e.g. a specific release.  However, leaving it commented out would mean quicker CI.
-gem 'bugsnag-maze-runner', git: 'https://github.com/bugsnag/maze-runner', tag: 'v7.17.0'
+gem 'bugsnag-maze-runner', '~> 7.0'
 
 # Use a specific branch
 #gem 'bugsnag-maze-runner', git: 'https://github.com/bugsnag/maze-runner', branch: 'master'