Default to allowing requests when checking connectivity #970
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fractalwrench
changed the title
fractalwrench
force-pushed
the
PLAT-5282/connectivity-fix
branch
from
d345a61 to
546106d
Compare
Android notifier sizes
Generated by 🚫 Danger |
tomlongridge
approved these changes
Oct 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Alters the behaviour in the
ConnectivityApi24class so that requests are allowed by default. The previous implementation has a bug wherehasNetworkConnection()would return false until theonAvailable()callback had been invoked by the Android framework. This has been resolved by queryingconnectivityManager#getActiveNetwork(), which will return null if there is no system default network available.Testing
Relied on existing E2E scenarios. Attempted running the artefact in a local app with and without network connection and confirmed that request delivery was done accordingly.