Prevent ConcurrentModificationException when setting redactedKeys #947
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Prevents a
ConcurrentModificationException
from being thrown whenredactedKeys
is set on theMetadata
of anEvent
. This can manifest as a crash whennotify()
is called concurrently.Changeset
ObjectJsonStreamer
to usevar Set<String>
rather thanval MutableSet<String>
, as this avoids the problem of mutating a collection concurrentlyredactedKeys
to a property onMetadata
rather than a property and function, as this is more consistentObjectJsonStreamer
from the constructor as there is no need for it to be injectableTesting
Added a unit test to verify that when
redactedKeys
is set onMetadata
a crash does not occur. Additionally added an integration test which callsnotify()
concurrently to confirm that no further crashes occur with the default configuration.