Attempt delivery of promise rejections immediately #912
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fractalwrench
force-pushed
the
promise-rejection-delivery
branch
from
d59db64 to
cf130d3
Compare
tomlongridge
approved these changes
Jul 29, 2020
Android notifier sizes
Generated by 🚫 Danger |
fractalwrench
force-pushed
the
promise-rejection-delivery
branch
from
cf130d3 to
4ca648d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Attempts to deliver promise rejections immediately. This is required for the React Native notifier where promise rejections are set as unhandled but do not terminate the process.
The logic in Android is now that unhandled events should only be delivered in the same process if they are an ANR or Promise Rejection.