Add null check when loading data from manifest #878
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Adds a null check when loading meta-data from the manifest. In a React Native 0.55 example app with no
meta-data
elements present in the manifest,applicationInfo.metadata
was returned as null by thePackageManager
.It's hypothesised that this was caused by a very old targetSdkVersion/compileSdkVersion, and can be demonstrated to be caused by the lack of any
meta-data
elements in the manifest, making this a relatively rare scenario. A null check has been added regardless.