Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefer using zero-based array when converting collection #461

Merged
merged 1 commit into from
Apr 15, 2019
Merged

Prefer using zero-based array when converting collection #461

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions sdk/src/main/java/com/bugsnag/android/ErrorReader.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -245,7 +245,7 @@ private static StackTraceElement[] readStackFrames(JsonReader reader) throws IOE
frames.add(readStackFrame(reader));
}
reader.endArray();
return frames.toArray(new StackTraceElement[frames.size()]);
return frames.toArray(new StackTraceElement[0]);
}

private static StackTraceElement readStackFrame(JsonReader reader) throws IOException {
Expand Down Expand Up @@ -396,7 +396,7 @@ private static ThreadState readThreadState(Configuration config, JsonReader read
}
}
reader.endArray();
return new ThreadState(threads.toArray(new CachedThread[threads.size()]));
return new ThreadState(threads.toArray(new CachedThread[0]));
}

private static CachedThread readThread(Configuration config,
Expand Down
2 changes: 1 addition & 1 deletion sdk/src/main/java/com/bugsnag/android/MetaData.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ static MetaData merge(@NonNull MetaData... metaDataList) {

@SuppressWarnings({"unchecked", "rawtypes"})
MetaData newMeta = new MetaData(mergeMaps(stores.toArray(new Map[0])));
newMeta.setFilters(filters.toArray(new String[filters.size()]));
newMeta.setFilters(filters.toArray(new String[0]));

return newMeta;
}
Expand Down
2 changes: 1 addition & 1 deletion sdk/src/main/java/com/bugsnag/android/ThreadState.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ public ThreadState(@NonNull Configuration config,
private Thread[] sortThreadsById(Map<Thread, StackTraceElement[]> liveThreads) {
Set<Thread> threadSet = liveThreads.keySet();

Thread[] threads = threadSet.toArray(new Thread[threadSet.size()]);
Thread[] threads = threadSet.toArray(new Thread[0]);
Arrays.sort(threads, new Comparator<Thread>() {
public int compare(@NonNull Thread lhs, @NonNull Thread rhs) {
return Long.valueOf(lhs.getId()).compareTo(rhs.getId());
Expand Down