Refactor language level migration #459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
we should prefer a switch statement for longer conditional branches (3+) as it reads better
fractalwrench
force-pushed
the
refactor-language-level-migration
branch
from
c342193 to
f6bb473
Compare
simonbowring
approved these changes
Apr 15, 2019
| reader.endObject(); | ||
| } else { | ||
| reader.skipValue(); | ||
| switch (name) { |
There was a problem hiding this comment.
Could just do switch (reader.nextName()) { as the name variable is only used once
| handled = reader.nextInt(); | ||
| } else { | ||
| reader.skipValue(); | ||
| switch (name) { |
| reader.beginObject(); | ||
| while (reader.hasNext()) { | ||
| String eventName = reader.nextName(); | ||
| switch (eventName) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes 3 changes as reported via Android Studio inspection: