Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only set ANR unwind function if the bugsnag-plugin-android-anr.so was loaded successfully #2039

Merged
merged 1 commit into from
Jun 19, 2024

Conversation

lemnik
Copy link
Contributor

@lemnik lemnik commented Jun 12, 2024

Goal

Avoid a crash if the bugsnag-plugin-android-anr.so library failed to load, when attempting to set the stack unwinder function.

Testing

Manually tested by removing the bugsnag-plugin-android-anr.so from a build

@lemnik lemnik requested a review from kstenerud June 12, 2024 16:20
@bugsnagbot
Copy link
Collaborator

bugsnagbot commented Jun 12, 2024

Android notifier sizes

Format Size impact of Bugsnag (kB) Size impact of Bugsnag when Minified (kB)
APK 1852.64 1674.84
arm64_v8a 631.04 450.82
armeabi_v7a 565.51 385.29
x86 704.75 528.62
x86_64 676.09 495.86

Generated by 🚫 Danger

@lemnik lemnik force-pushed the lemnik/safe-set-unwind branch from 9703818 to 6185b9f Compare June 13, 2024 06:59
@lemnik lemnik force-pushed the lemnik/safe-set-unwind branch from 6185b9f to 3f93a04 Compare June 13, 2024 12:34
@lemnik lemnik merged commit b9f5560 into next Jun 19, 2024
26 checks passed
@lemnik lemnik deleted the lemnik/safe-set-unwind branch June 19, 2024 10:18
@YYChen01988 YYChen01988 mentioned this pull request Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants