NDK metadata iterator #2035
Merged
NDK metadata iterator #2035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Android notifier sizes
Generated by 🚫 Danger |
Cawllec
approved these changes
May 30, 2024
|
I've rebased and re-tested using the instrumentation tests. They now pass with this change. |
kstenerud
approved these changes
Jun 3, 2024
…nstead of using ArrayList
…o to avoid strcnpy_chk
lemnik
force-pushed
the
PLAT-12075/ndk-metadata-iterator
branch
from
b21630a to
af3f5bc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Reduce the overhead of copying Metadata into the NDK layer. This PR includes some minor fixes to existing tests.
Design
Directly iterate over the
Map.entrySetinstead of first copying all of the keys to a temporaryArrayList. Since the most commonMapimplementations maintain their data inMap.Entryobjects, this has significantly lower overheads and complexity than the previous pattern.Testing
Relied on existing tests.