Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow early session starts in auto mode #2006

Merged
merged 6 commits into from
Apr 10, 2024

Conversation

YYChen01988
Copy link
Contributor

@YYChen01988 YYChen01988 commented Apr 8, 2024

Goal

Allow Bugsnag.startSession to be called with automatic session tracking, and not have the first manual session be over written by the first automatic session.

Design

The first automatically started session will be discarded if there is already a manually started session. All subsequent sessions behave as previous.

Testing

Manual testing and end to end test

@YYChen01988 YYChen01988 requested a review from lemnik April 8, 2024 08:09
@YYChen01988 YYChen01988 force-pushed the PLAT-11867/allow_early_session_starts_in_auto_mode branch from 2cc1142 to f602325 Compare April 8, 2024 08:12
@bugsnagbot
Copy link
Collaborator

bugsnagbot commented Apr 8, 2024

Android notifier sizes

Format Size impact of Bugsnag (kB) Size impact of Bugsnag when Minified (kB)
APK 1843.89 1668.06
arm64_v8a 626.95 450.82
armeabi_v7a 561.42 385.29
x86 700.66 524.53
x86_64 671.99 495.86

Generated by 🚫 Danger

@YYChen01988 YYChen01988 force-pushed the PLAT-11867/allow_early_session_starts_in_auto_mode branch from f602325 to ddba97f Compare April 8, 2024 08:15
@YYChen01988 YYChen01988 force-pushed the PLAT-11867/allow_early_session_starts_in_auto_mode branch 2 times, most recently from 9145a4d to b82fe3e Compare April 8, 2024 08:25
@YYChen01988 YYChen01988 force-pushed the PLAT-11867/allow_early_session_starts_in_auto_mode branch 4 times, most recently from 54847e1 to f348f0c Compare April 8, 2024 14:14
@YYChen01988 YYChen01988 requested a review from lemnik April 8, 2024 14:18
@YYChen01988 YYChen01988 force-pushed the PLAT-11867/allow_early_session_starts_in_auto_mode branch from f348f0c to 2234dd7 Compare April 8, 2024 14:43
Copy link
Contributor

@lemnik lemnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@YYChen01988 YYChen01988 merged commit 43e4cc8 into next Apr 10, 2024
26 checks passed
@YYChen01988 YYChen01988 deleted the PLAT-11867/allow_early_session_starts_in_auto_mode branch April 10, 2024 07:39
@YYChen01988 YYChen01988 mentioned this pull request Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants