-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow early session starts in auto mode #2006
Merged
YYChen01988
merged 6 commits into
next
from
PLAT-11867/allow_early_session_starts_in_auto_mode
Apr 10, 2024
Merged
Allow early session starts in auto mode #2006
YYChen01988
merged 6 commits into
next
from
PLAT-11867/allow_early_session_starts_in_auto_mode
Apr 10, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2cc1142
to
f602325
Compare
Android notifier sizes
Generated by 🚫 Danger |
f602325
to
ddba97f
Compare
9145a4d
to
b82fe3e
Compare
lemnik
reviewed
Apr 8, 2024
bugsnag-android-core/src/main/java/com/bugsnag/android/SessionTracker.java
Outdated
Show resolved
Hide resolved
bugsnag-android-core/src/main/java/com/bugsnag/android/SessionTracker.java
Outdated
Show resolved
Hide resolved
54847e1
to
f348f0c
Compare
f348f0c
to
2234dd7
Compare
lemnik
approved these changes
Apr 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Allow
Bugsnag.startSession
to be called with automatic session tracking, and not have the first manual session be over written by the first automatic session.Design
The first automatically started session will be discarded if there is already a manually started session. All subsequent sessions behave as previous.
Testing
Manual testing and end to end test