Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NDK read primitives #1967

Merged
merged 2 commits into from
Jan 31, 2024

Conversation

lemnik
Copy link
Contributor

@lemnik lemnik commented Jan 26, 2024

Goal

Implement ByteBuffer utility functions to read C primitives in Kotlin, handling cases where they are machine-architecture dependent.

Testing

New unit tests with data taken from event dumps.

@lemnik lemnik requested review from kstenerud and a user January 26, 2024 17:19
@bugsnagbot
Copy link
Collaborator

bugsnagbot commented Jan 26, 2024

Android notifier sizes

Format Size impact of Bugsnag (kB) Size impact of Bugsnag when Minified (kB)
APK 1842.16 1668.28
arm64_v8a 626.95 450.82
armeabi_v7a 561.42 385.29
x86 700.66 524.53
x86_64 671.99 495.86

Generated by 🚫 Danger

@lemnik lemnik force-pushed the PLAT-11486/ndk-read-primitives branch from 16267d2 to f2b04e9 Compare January 31, 2024 09:08
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lemnik lemnik force-pushed the PLAT-11486/ndk-read-primitives branch from f2b04e9 to 064ff38 Compare January 31, 2024 13:13
@lemnik lemnik force-pushed the PLAT-11486/ndk-read-primitives branch from 064ff38 to d32ec1a Compare January 31, 2024 13:16
@lemnik lemnik merged commit 2223c41 into integration/ndk-event-decoder Jan 31, 2024
23 checks passed
@lemnik lemnik deleted the PLAT-11486/ndk-read-primitives branch January 31, 2024 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants