Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated Configuration.launchCrashThresholdMs #1937

Merged
merged 1 commit into from
Nov 15, 2023

Conversation

lemnik
Copy link
Contributor

@lemnik lemnik commented Nov 15, 2023

Goal

Remove Configuration.getLaunchCrashThresholdMs and Configuration.setLaunchCrashThresholdMs as they were marked as deprecated for removal.

Testing

Relied on existing tests.

@lemnik lemnik requested review from tomlongridge and a user November 15, 2023 11:39
@bugsnagbot
Copy link
Collaborator

Android notifier sizes

Format Size impact of Bugsnag (kB) Size impact of Bugsnag when Minified (kB)
APK 1841.22 1668.96
arm64_v8a 622.85 450.82
armeabi_v7a 557.32 385.29
x86 700.66 524.53
x86_64 667.9 495.86

Generated by 🚫 Danger

@lemnik lemnik force-pushed the lemnik/remove-deprecated-config branch from 5696779 to 600b8d3 Compare November 15, 2023 11:40
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lemnik lemnik merged commit 6620cd3 into integration/v6 Nov 15, 2023
@lemnik lemnik deleted the lemnik/remove-deprecated-config branch November 15, 2023 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants