Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prefab support for bugsnag-plugin-android-ndk #1921

Merged
merged 6 commits into from
Nov 8, 2023
Merged

Prefab support for bugsnag-plugin-android-ndk #1921

merged 6 commits into from
Nov 8, 2023

Conversation

lemnik
Copy link
Contributor

@lemnik lemnik commented Oct 25, 2023

Goal

Support linking to bugsnag-plugin-android-ndk via prefabs.

Changes

  • bugsnag-plugin-android-ndk is now published with a bugsnag-ndk prefab module (in addition to the standard jniLibs)
  • Mazerunner is no longer built with NDK 16.1.4479499 as it fails to generate the cmake files for prefabs.

Testing

Modified the existing Mazerunner fixture to use prefabs instead of manually unpacking the .so files

@lemnik lemnik requested review from twometresteve, tomlongridge and a user October 25, 2023 16:55
@bugsnagbot
Copy link
Collaborator

bugsnagbot commented Oct 25, 2023 •
edited
Loading

Android notifier sizes

Format Size impact of Bugsnag (kB) Size impact of Bugsnag when Minified (kB)
APK 1866.15 1697.88
arm64_v8a 627.08 459.15
armeabi_v7a 565.65 393.62
x86 704.89 532.86
x86_64 672.13 504.19

Generated by 🚫 Danger

tomlongridge
tomlongridge approved these changes Nov 1, 2023
View reviewed changes
Copy link
Contributor

@tomlongridge tomlongridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - one minor comment (just to show I'm looking!)

@lemnik lemnik force-pushed the PLAT-11124/prefabs branch 3 times, most recently from 780029f to a401bd4 Compare November 2, 2023 08:03
@lemnik lemnik force-pushed the PLAT-11124/prefabs branch from a401bd4 to 2e9c428 Compare November 2, 2023 10:03
@lemnik lemnik force-pushed the PLAT-11124/prefabs branch from 24764f1 to 40db5e2 Compare November 2, 2023 10:35
@twometresteve
Copy link
Contributor

docs/ENVIRONMENT_SETUP.md still contains a reference to "r16", I'm guessing that can be removed now?

twometresteve
twometresteve approved these changes Nov 6, 2023
View reviewed changes
Copy link
Contributor

@twometresteve twometresteve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI aspects LGTM

ghost
ghost approved these changes Nov 7, 2023
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tomlongridge tomlongridge merged commit 0729928 into integration/v6 Nov 8, 2023
@tomlongridge tomlongridge deleted the PLAT-11124/prefabs branch November 8, 2023 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@twometresteve twometresteve twometresteve approved these changes

@tomlongridge tomlongridge tomlongridge approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lemnik @bugsnagbot @twometresteve @tomlongridge