Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configuration.persistUser should be true by default #1867

Merged

Conversation

ghost
Copy link

@ghost ghost commented Jul 13, 2023

Goal

Reset persist user default value to match with other platforms.

Changeset

Changed persist user default value to true

Testing

Updated the existing tests

@ghost ghost requested a review from lemnik July 13, 2023 13:56
@bugsnagbot
Copy link
Collaborator

bugsnagbot commented Jul 13, 2023

Android notifier sizes

Format Size impact of Bugsnag (kB) Size impact of Bugsnag when Minified (kB)
APK 1866.17 1697.65
arm64_v8a 627.08 459.15
armeabi_v7a 565.65 393.62
x86 704.89 532.86
x86_64 672.13 504.19

Generated by 🚫 Danger

@ghost ghost force-pushed the PLAT-6172_setting_persistUser_default_value_to_true branch from 44878f8 to ba0790e Compare July 13, 2023 15:31
Copy link
Contributor

@lemnik lemnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lemnik lemnik merged commit 73e5a70 into integration/v6 Jul 14, 2023
@lemnik lemnik deleted the PLAT-6172_setting_persistUser_default_value_to_true branch July 14, 2023 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants