Activity breadcrumbs should report their own "previous" state #1818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lemnik
force-pushed
the
PLAT-9820/fix-previous-activity-state
branch
from
3db765f to
4d6f15d
Compare
Android notifier sizes
Generated by 🚫 Danger |
lemnik
force-pushed
the
PLAT-9820/fix-previous-activity-state
branch
from
4d6f15d to
392f501
Compare
kstenerud
approved these changes
Mar 15, 2023
lemnik
force-pushed
the
PLAT-9820/fix-previous-activity-state
branch
from
392f501 to
35bcc63
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Fix 1817 by associating the "previous" state with its Activity.
Changeset
Replace the global "previous" state with a
WeakHashMap<Activity, String>. When anActivity.onDestroyis called theActivityis preemptively removed from the map. Since the activity lifecycle callbacks are always invoked from the main thread, access to theWeakHashMapis left unsynchronized.Testing
A new unit test was added testing interleaved Activity lifecycles.