Add IntRange annotations to applicable configuration so that Android Studio can warn users #1808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Android notifier sizes
Generated by 🚫 Danger |
hannah-smartbear
force-pushed
the
PLAT-8699/add-int-range-annotations-to-applicable-configuration
branch
from
3799f32 to
6e357e5
Compare
lemnik
reviewed
Feb 13, 2023
CHANGELOG.md
Outdated
| @@ -1,5 +1,12 @@ | |||
| # Changelog | |||
|
|
|||
| ## TBD | |||
|
|
|||
| ### Bug fixes | |||
There was a problem hiding this comment.
Suggested change
| ### Bug fixes | |
| ### Enhancements |
lemnik
force-pushed
the
PLAT-8699/add-int-range-annotations-to-applicable-configuration
branch
from
00a81f9 to
b646c27
Compare
…Studio can warn users
hannah-smartbear
force-pushed
the
PLAT-8699/add-int-range-annotations-to-applicable-configuration
branch
from
b646c27 to
087c3cb
Compare
…cable-configuration
hannah-smartbear
deleted the
PLAT-8699/add-int-range-annotations-to-applicable-configuration
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added an @IntRange annotation to any configuration options that had hard limits on integer ranges, so that Android Studio can warn users when they try to set a configuration option to a number outside the range of options without them having to read the code, documentation or experience a runtime warning.
Tested this by building the library with my changes locally and checking if the example app gave me a warning in android studio when I set a configuration option to be outside the range.