Correctly truncate long strings from nested metadata structures #1778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lemnik
force-pushed
the
PLAT-9142/truncate-nested-metadata
branch
from
f76d323 to
8eeb6d4
Compare
lemnik
force-pushed
the
PLAT-9142/truncate-nested-metadata
branch
from
8eeb6d4 to
29672f7
Compare
Android notifier sizes
Generated by 🚫 Danger |
kstenerud
approved these changes
Nov 7, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Trim strings nested in complex metadata (nested lists, maps or other collections) when they are over the configured "maximum length".
Testing
Introduced a new unit test for
StringUtilsto ensure all the string trimming code is properly covered