Attempt delivery on crash if configured #1749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lemnik
force-pushed
the
PLAT-8969/attempt-delivery-on-crash
branch
from
e8554c5 to
f1da738
Compare
Android notifier sizes
Generated by 🚫 Danger |
lemnik
force-pushed
the
PLAT-8969/attempt-delivery-on-crash
branch
3 times, most recently
from
2129dac to
0ec3bf5
Compare
kstenerud
reviewed
Oct 4, 2022
| @@ -55,7 +56,11 @@ void deliver(@NonNull Event event) { | |||
| String severityReasonType = event.getImpl().getSeverityReasonType(); | |||
| boolean promiseRejection = REASON_PROMISE_REJECTION.equals(severityReasonType); | |||
| boolean anr = event.getImpl().isAnr(event); | |||
| cacheEvent(event, anr || promiseRejection); | |||
| if (immutableConfig.getAttemptDeliveryOnCrash()) { | |||
| cacheAndSendSynchronously(event); | |||
There was a problem hiding this comment.
DeliveryDelegate.deliver gets called for all kinds of higher level errors, including ANRs and handled errors (via Client.populateAndNotifyAndroidEvent). I don't think we should be blocking the thread for ANRs and non-fatal events.
There was a problem hiding this comment.
I agree on ANRs and such. I'll modify the order of these if checks to only act on unhandled errors that were not previously attemptSend.
lemnik
force-pushed
the
PLAT-8969/attempt-delivery-on-crash
branch
from
0ec3bf5 to
709819a
Compare
… `ImmutableConfig` and allow a 3 second timeout during crash to attempt delivery
lemnik
force-pushed
the
PLAT-8969/attempt-delivery-on-crash
branch
from
709819a to
bf249d7
Compare
kstenerud
approved these changes
Oct 5, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Attempt to deliver crashes when they happen if configured.
Design
The
DeliveryDelegate.cacheEventflag forattemptSentnow attempts immediate delivery of just that single eventTesting
A new test scenario was introduced to test that a crash can be delivered without a fixture restart.