Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow any Collection to be encoded as OPAQUE in NDK metadata #1728

Merged
merged 1 commit into from
Aug 9, 2022

Conversation

lemnik
Copy link
Contributor

@lemnik lemnik commented Aug 8, 2022

Goal

Allow any valid Collection to be encoded as OPAQUE NDK metadata

Testing

Additional values in the end to end test

@lemnik lemnik force-pushed the PLAT-8756/ndk-metadata-collections branch from 419a0c4 to 70bef5f Compare August 8, 2022 16:23
@bugsnagbot
Copy link
Collaborator

bugsnagbot commented Aug 9, 2022

Android notifier sizes

Format Size impact of Bugsnag (kB) Size impact of Bugsnag when Minified (kB)
APK 1879.44 1637.05
arm64_v8a 659.85 418.19
armeabi_v7a 594.32 356.75
x86 733.56 495.99
x86_64 704.9 463.23

Generated by 🚫 Danger

@lemnik lemnik force-pushed the PLAT-8756/ndk-metadata-collections branch 2 times, most recently from a6da405 to f8c4fda Compare August 9, 2022 07:55
@lemnik lemnik force-pushed the PLAT-8756/ndk-metadata-collections branch from f8c4fda to 2557b30 Compare August 9, 2022 11:14
@lemnik lemnik requested a review from nickdowell August 9, 2022 14:54
@lemnik lemnik merged commit 2588d13 into next Aug 9, 2022
@lemnik lemnik deleted the PLAT-8756/ndk-metadata-collections branch August 9, 2022 16:16
@lemnik lemnik mentioned this pull request Aug 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants