Make discard classes apply to native crashes as well #1710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kstenerud
force-pushed
the
PLAT-7837-discard-classes
branch
from
2f36cbf to
53f5225
Compare
Android notifier sizes
Generated by 🚫 Danger |
kstenerud
force-pushed
the
PLAT-7837-discard-classes
branch
2 times, most recently
from
c7e1868 to
76b970d
Compare
kstenerud
force-pushed
the
PLAT-7837-discard-classes
branch
from
76b970d to
c0d8c5c
Compare
lemnik
approved these changes
Jun 23, 2022
This was referenced Jun 29, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Also filter out NDK events based on the discard classes config setting.
Design
The NDK now queries the JVM to see if an event class is on the discard list before generating a payload to be sent.
Testing
Added e2e tests.