[PLAT-8191] Add Bugsnag.isStarted #1640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomlongridge
force-pushed
the
jallen/bugsnag-isstarted
branch
from
33d9ee7 to
a427799
Compare
Closed
Merged
jgreen210
reviewed
Jan 17, 2023
| * other methods will throw IllegalStateException. | ||
| */ | ||
| public static boolean isStarted() { | ||
| return client != null; |
There was a problem hiding this comment.
This isn't thread safe - it's using the field directly without obtaining the lock. It could be made thread safe by using getClient() not client. I made #1795 for this.
There was a problem hiding this comment.
You could use a https://developer.android.com/reference/androidx/annotation/GuardedBy annotation on the client field to document the locking requirement.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
From #1621:
Raised internally for CI and merge purposes.