Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport persistenceDirectory config option #1532

Merged
merged 6 commits into from
Dec 2, 2021

Conversation

fractalwrench
Copy link
Contributor

@fractalwrench fractalwrench commented Nov 26, 2021

Goal

Backports the persistenceDirectory option to allow controlling where errors/native crashes/sessions are stored: #998

Testing

Manually verified that errors make it through to the dashboard in a vanilla Android app and they can be stored in either the cacheDir or filesDir. Added unit test coverage.

Screenshot 2021-11-26 at 11 05 43

@fractalwrench fractalwrench requested a review from lemnik November 26, 2021 11:23
Copy link
Contributor

@lemnik lemnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - With one minor comment

@fractalwrench fractalwrench force-pushed the PLAT-7654/backport-persistence-dir branch from aa36244 to 65efb11 Compare November 29, 2021 15:28
@bugsnagbot
Copy link
Collaborator

bugsnagbot commented Nov 29, 2021

Android notifier sizes

Format Size impact of Bugsnag (kB) Size impact of Bugsnag when Minified (kB)
APK 1387.52 1384.66
arm64_v8a 331.53 329.02
armeabi 311.74 309.2
armeabi_v7a 294.31 291.79
x86 369.66 367.14
x86_64 353.39 350.85

Generated by 🚫 Danger

@fractalwrench
Copy link
Contributor Author

I've added two commits as the persistenceDirectory was wrong for the SessionStore due to its place in the constructor - this was picked up by an E2E test.

@fractalwrench fractalwrench requested a review from lemnik November 29, 2021 16:54
Copy link
Contributor

@lemnik lemnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fractalwrench fractalwrench merged commit 80cfdf8 into cocos2dx-main Dec 2, 2021
@fractalwrench fractalwrench deleted the PLAT-7654/backport-persistence-dir branch December 2, 2021 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants