-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backport persistenceDirectory config option #1532
Backport persistenceDirectory config option #1532
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - With one minor comment
bugsnag-android-core/src/androidTest/java/com/bugsnag/android/BugsnagTestUtils.java
Outdated
Show resolved
Hide resolved
aa36244
to
65efb11
Compare
Android notifier sizes
Generated by 🚫 Danger |
I've added two commits as the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Goal
Backports the
persistenceDirectory
option to allow controlling where errors/native crashes/sessions are stored: #998Testing
Manually verified that errors make it through to the dashboard in a vanilla Android app and they can be stored in either the cacheDir or filesDir. Added unit test coverage.