OnSend Callback Implementation #1524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat(onsend): added the `OnSendCallback` interface and support functions * feat(onsend): add dsl-json and encapsulate Event unmarsalling in EventSource
Plat 7599/onsend port
Parse SeverityReason
…onsend Parse Stacktrace for OnSend Callbacks
Parse Thread for OnSend Callbacks
…onsend Parse DeviceWithState and AppWithState for OnSendCallbacks
…onsend Parse Breadcrumbs for OnSend Callbacks
Parse Event for OnSend Callbacks
Mazerunner test for the OnSend callback
fractalwrench
approved these changes
Nov 25, 2021
| }, | ||
|
|
||
| // threads included | ||
| createEvent { | ||
| it.addMetadata("app", "foo", 55) | ||
| it.addMetadata("device", "bar", true) | ||
| it.addMetadata("wham", "some_key", "A value") | ||
| it.addMetadata("wham", "some_key", "Avalue") |
There was a problem hiding this comment.
It'd be good to resolve issues with spacing in the JSON tests before merging
…ding whitespace into string literals
Update onsend-next to next and align tests
Since events begin being sent during start(), it would be inadvisable to add a callback after configuration, as events may be mistakenly missed. This method was not public anyhow. [full ci]
Android notifier sizes
Generated by 🚫 Danger |
# Conflicts: # bugsnag-android-core/src/main/java/com/bugsnag/android/Client.java # bugsnag-android-core/src/main/java/com/bugsnag/android/DeliveryDelegate.java # bugsnag-android-core/src/main/java/com/bugsnag/android/EventInternal.kt # bugsnag-android-core/src/test/java/com/bugsnag/android/DeliveryDelegateTest.kt
Merge `next` into onsend-next branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Introduce OnSend Callbacks for
next, allowing first-party plugins to intercept the delivery of an event, and alter the event payload before the upload. This is mostly based on previous work from integration/onsend-callback which targeted the Journal branch. This new branch is based onnextand provides the same functionality there.Testing
Deserialization of the events is covered by unit tests, leveraging the same test fixtures as the existing serialization tests. A new Mazeunner scenario has been added to ensure the process works when integrated into an application.